> On March 3, 2015, 11:48 p.m., Albert Astals Cid wrote:
> > That increases the minimum Qt dependency to Qt 5.3.1 for all of the uses
> > here, is this something we want? At least it should be documented.
I don't think it would be too hard to make this optional:
if(TARGET Qt5::lconvert)
set(lconvert_executable Qt5::lconvert)
else()
# current hack
endif()
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122626/#review76974
-----------------------------------------------------------
On March 3, 2015, 11:11 a.m., Dmitry Shachnev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122626/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 11:11 a.m.)
>
>
> Review request for Build System, Aurélien Gâteau and Harald Sitter.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> The old hacks were not working in some configurations (i.e. when there is
> `/usr/bin/lconvert` managed by qtchooser, but no qtchooser configuration
> file).
>
> Qt5LinguistToolsConfig.cmake defines CMake target for `lconvert` since Qt
> 5.3.1, so we can use that instead.
>
>
> Diffs
> -----
>
> modules/ECMCreateQmFromPoFiles.cmake 3f134fb
> modules/ECMPoQmTools.cmake 015b7f9
>
> Diff: https://git.reviewboard.kde.org/r/122626/diff/
>
>
> Testing
> -------
>
> Build qapt in clean Debian sid chroot. Previously it was failing with
> qtchooser error, now succeeds.
>
>
> Thanks,
>
> Dmitry Shachnev
>
>
_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem
