> On April 3, 2015, 5:35 p.m., Andrius da Costa Ribas wrote:
> > src/CMakeLists.txt, line 20
> > <https://git.reviewboard.kde.org/r/120648/diff/2/?file=320785#file320785line20>
> >
> > It's already committed (but there's been a long time since I hadn't
> > build anything), but now I see that DocBookXML4_DTD_DIR is used only inside
> > the "else(NOT WIN32)" part, is this what's been intended? Also, this
> > doesn't work when the original DocBookXML4_DTD_DIR is an absolute Windows
> > path "V:" becomes "V%3A" and xmllint fails to recognise it as an absolute
> > path (see below) and CMake would fail to install to such location. (maybe
> > we should prepend it with "file://" ?)
> >
> >
> >
> >
> > file:///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/kdedbx45.dtd:102:
> > warning: failed to load external
> >
> > ///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/v%3A/share/xml/docbook/schema/dtd/4.5/docbookx.dtd"
> > %DocBookDTD;
- DocBookXML4_DTD_DIR is properly touched both for non WIN32 (line 4) and WIN32
(lines 4 and 20). The WIN32 logic is a bit complicated, but basically it
rewrites again the generated ${_custom_dtd_kdex} file using the DTD path which
is knows during the installation. Or something like that.
- Oh, that's the feedback I was looking for. Can you please copy the exact
content of the path to docbookx.dtd as referenced into kdedbx45.dtd?
- Luigi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78442
-----------------------------------------------------------
On Feb. 28, 2015, 11:02 p.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120648/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2015, 11:02 p.m.)
>
>
> Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,
> and kdewin.
>
>
> Repository: kdoctools
>
>
> Description
> -------
>
> The URI need to be encoded, because some valid characters for
> filenames are not valid according RFC 2396.
> Easy way to trigger the issue: when the path contains spaces,
> as it happens on MacOSX builds.
>
> See also https://git.reviewboard.kde.org/r/120649/ for the twin review on
> kdelibs4support.
>
>
> Diffs
> -----
>
> cmake/uriencode.cmake PRE-CREATION
> src/CMakeLists.txt 341ecf4
>
> Diff: https://git.reviewboard.kde.org/r/120648/diff/
>
>
> Testing
> -------
>
> It compiles, but I can't properly test Mac and Windows scenarios
>
>
> Thanks,
>
> Luigi Toscano
>
>
_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem
