> On May 25, 2015, 12:34 p.m., Alex Merry wrote:
> > Linking against the QtCore target should bring in any flags necessary to
> > make that link succeed. If it doesn't, that's a problem with Qt's CMake
> > targets.
> >
> > Thiago's email to the list suggested that had been resolved in the 5.4.2
> > branch. Could you check that and confirm, please?
No it is not resolved for *this* case. Linking to Qt5Core works fine. Trouble
is with check_qt_visibility.cpp:
```
#include <QtCore/QtGlobal>
int main()
{
#ifndef QT_VISIBILITY_AVAILABLE
#error QT_VISIBILITY_AVAILABLE is not available
#endif
}
```
and try_compile is called only with ${_include_dirs}
- Hrvoje
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123874/#review80804
-----------------------------------------------------------
On May 22, 2015, 6:45 a.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123874/
> -----------------------------------------------------------
>
> (Updated May 22, 2015, 6:45 a.m.)
>
>
> Review request for Build System, Phonon and Harald Sitter.
>
>
> Repository: phonon
>
>
> Description
> -------
>
> Or to be more accurate, with commit 3eca75de67b3fd2c890715b30c7899cebc096fe9
> I am not convinced this is best solution, but requires least changes to
> current cmake code.
>
>
> Diffs
> -----
>
> cmake/FindPhononInternal.cmake 44862b5
>
> Diff: https://git.reviewboard.kde.org/r/123874/diff/
>
>
> Testing
> -------
>
> Builds with 5.4.2 branch, or mentioned commit backported.
> Otherwise check_qt_visibility fails:
>
> ```
> [ 126s] -- Performing Test __KDE_HAVE_GCC_VISIBILITY - Success
> [ 126s] Change Dir:
> /home/abuild/rpmbuild/BUILD/phonon-4.8.3/build/CMakeFiles/CMakeTmp
> [ 126s]
> [ 126s] Run Build Command:"/usr/bin/gmake" "cmTryCompileExec3719375587/fast"
> [ 126s] /usr/bin/gmake -f
> CMakeFiles/cmTryCompileExec3719375587.dir/build.make
> CMakeFiles/cmTryCompileExec3719375587.dir/build
> [ 126s] gmake[1]: Entering directory
> '/home/abuild/rpmbuild/BUILD/phonon-4.8.3/build/CMakeFiles/CMakeTmp'
> [ 126s] /usr/bin/cmake -E cmake_progress_report
> /home/abuild/rpmbuild/BUILD/phonon-4.8.3/build/CMakeFiles/CMakeTmp/CMakeFiles
> 1
> [ 126s] Building CXX object
> CMakeFiles/cmTryCompileExec3719375587.dir/check_qt_visibility.cpp.o
> [ 126s] /usr/bin/c++ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall
> -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables
> -fasynchronous-unwind-tables -g -DNDEBUG -Wnon-virtual-dtor -Wno-long-long
> -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith
> -Wformat-security -fno-exceptions -DQT_NO_EXCEPTIONS -fno-check-new
> -fno-common -Woverloaded-virtual -fvisibility=hidden -fPIE
> -I/usr/include/qt5 -I/usr/include/qt5/QtCore
> -I/usr/lib64/qt5/mkspecs/linux-g++ -I/usr/include/qt5/QtWidgets
> -I/usr/include/qt5/QtGui -o
> CMakeFiles/cmTryCompileExec3719375587.dir/check_qt_visibility.cpp.o -c
> /home/abuild/rpmbuild/BUILD/phonon-4.8.3/build/CMakeTmp/check_qt_visibility.cpp
> [ 126s] In file included from /usr/include/qt5/QtCore/QtGlobal:1:0,
> [ 126s] from
> /home/abuild/rpmbuild/BUILD/phonon-4.8.3/build/CMakeTmp/check_qt_visibility.cpp:1:
> [ 126s] /usr/include/qt5/QtCore/qglobal.h:1051:4: error: #error "You must
> build your code with position independent code if Qt was built with
> -reduce-relocations. " "Compile your code with -fPIC (-fPIE is not enough)."
> [ 126s] # error "You must build your code with position independent code
> if Qt was built with -reduce-relocations. "\
> [ 126s] ^
> [ 126s] CMakeFiles/cmTryCompileExec3719375587.dir/build.make:57: recipe for
> target 'CMakeFiles/cmTryCompileExec3719375587.dir/check_qt_visibility.cpp.o'
> failed
> [ 126s] gmake[1]: Leaving directory
> '/home/abuild/rpmbuild/BUILD/phonon-4.8.3/build/CMakeFiles/CMakeTmp'
> [ 126s] gmake[1]: ***
> [CMakeFiles/cmTryCompileExec3719375587.dir/check_qt_visibility.cpp.o] Error 1
> [ 126s] Makefile:117: recipe for target 'cmTryCompileExec3719375587/fast'
> failed
> [ 126s] gmake: *** [cmTryCompileExec3719375587/fast] Error 2
> [ 126s]
> [ 126s] CMake Error at cmake/FindPhononInternal.cmake:416 (message):
> [ 126s] Qt compiled without support for -fvisibility=hidden. This will
> break
> [ 126s] plugins and linking of some applications. Please fix your Qt
> installation
> [ 126s] (try passing --reduce-exports to configure).
> [ 126s] Call Stack (most recent call first):
> [ 126s] CMakeLists.txt:47 (include)
> ```
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem
