> On June 4, 2015, 10:28 p.m., Hrvoje Senjan wrote: > > cmake/PhononQt5.cmake, line 39 > > <https://git.reviewboard.kde.org/r/124009/diff/1/?file=378830#file378830line39> > > > > LGTM. > > This function though could now be named differently? ;-) > > > > (or maybe you want to use KDEInstallDirs to all the paths from there?)
long-term (if we end up with phonon4 api long term anyway), it probably should move to kdeinstalldirs. currently such a move is only blocked by the fact that the names we use are non-kde specific, so changing those would require changing all their uses across phonon and all backends which seems yet more invasive. - Harald ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124009/#review81217 ----------------------------------------------------------- On June 4, 2015, 8:53 p.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124009/ > ----------------------------------------------------------- > > (Updated June 4, 2015, 8:53 p.m.) > > > Review request for Build System, Phonon, Martin Gräßlin, and Hrvoje Senjan. > > > Repository: phonon > > > Description > ------- > > - qt4 as before > - qt5 now uses ECM to set compiler flags and so forth > - paths are still coming out of the joint finder file as the variable names > in ECM are different and will potentially cause regressions > > > Diffs > ----- > > cmake/CMakeLists.txt c31d4dd88d49a7aa2ed6df3c5349f34a5cdbf916 > cmake/FindPhononInternal.cmake 045f777af4d4cb9c9cf707bf72102c92999f490b > cmake/PhononQt4.cmake PRE-CREATION > cmake/PhononQt5.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124009/diff/ > > > Testing > ------- > > ran cmake with both lineups and it passes, so yay, I guess. > > kinda crap to test properly > > > Thanks, > > Harald Sitter > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
