-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124892/
-----------------------------------------------------------
(Updated Aug. 23, 2015, 1:26 p.m.)
Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,
Plasma, and Harald Sitter.
Bugs: 342962
https://bugs.kde.org/show_bug.cgi?id=342962
Repository: kdeclarative
Description
-------
The kdeclarative plugins (draganddropplugin, kcoreaddonsplugin, kio,
kquickcontrolsprivateplugin, and kquickcontrolsaddonsplugin) are being built as
shared libraries. They should be built as bundles (MODULE) in the
CMakeLists.txt file.
When built as SHARED as in the current code, libdraganddropplugin.dylib gets
installed to $PREFIX/share/qt5/qml/org/kde/draganddrop, but is given an OS X
install_name of $PREFIX/lib/libdraganddropplugin.dylib. This mismatch can cause
problems. It is also given a compatibility_version of 0.0.0.
Diffs
-----
src/qmlcontrols/draganddrop/CMakeLists.txt e8127e4
src/qmlcontrols/kcoreaddons/CMakeLists.txt 3f77f2d
src/qmlcontrols/kioplugin/CMakeLists.txt 7b258e0
src/qmlcontrols/kquickcontrols/private/CMakeLists.txt da355c1
src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1
Diff: https://git.reviewboard.kde.org/r/124892/diff/
Testing
-------
Since the plugin is not supposed to be a linkable library, it should be built
as MODULE in CMakeLists.txt. The physical install location remains the same and
plugins don't have install_names. This corrects the install_name/install
location mismatch. The change should not have any effect on non-OS X systems.
Thanks,
Hanspeter Niederstrasser
_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem
