----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125375/#review85895 -----------------------------------------------------------
This file doesn't behave at all like find modules usually do. Instead of generating a config file, it should use components, and it shouldn't provide a version macro, but should parse out the version itself. It should be much more in the style of FindWayland.cmake. In short, this module needs rewriting from scratch. Also, if there is only one project that needs it, I would suggest just shipping it directly in that project. ECM follows the "two or more users" rule in general - there needs to be two or more downstream users to justify shipping it in ECM. - Alex Merry On Sept. 24, 2015, 3:21 p.m., Boudhayan Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125375/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 3:21 p.m.) > > > Review request for Build System and Alex Merry. > > > Repository: extra-cmake-modules > > > Description > ------- > > Move FindAlsa from attic to find-modules. libKCompactDisc would like to use > it. > > EDIT: For some reason git diff generates an empty file after I git add the > files, but here's the git status output: > > $: git status > On branch master > Your branch is up-to-date with 'origin/master'. > Changes to be committed: > (use "git reset HEAD <file>..." to unstage) > > renamed: attic/modules/FindAlsa.cmake -> > find-modules/FindAlsa.cmake > renamed: attic/modules/config-alsa.h.cmake -> > find-modules/config-alsa.h.cmake > > > Diffs > ----- > > attic/modules/FindAlsa.cmake 1bad812 > attic/modules/config-alsa.h.cmake fb9cb8c > find-modules/FindAlsa.cmake PRE-CREATION > find-modules/config-alsa.h.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125375/diff/ > > > Testing > ------- > > > Thanks, > > Boudhayan Gupta > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
