----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125631/ -----------------------------------------------------------
Review request for Extra Cmake Modules and Volker Krause. Repository: extra-cmake-modules Description ------- ECMInstallIcons now updates the theme cache if gtk-update-icon-cache is available, producing files the test hadn't been expecting.. Updating the test revealed that the old-style ecm_install_icons call only updated the hicolor cache, and not any of the other themes. Diffs ----- modules/ECMInstallIcons.cmake 920c94908e2de4177eb4966317ade74d3bda89e9 tests/ECMInstallIconsTest/CMakeLists.txt 7fe4ca35568ddb4aa6abecdc2f24de559f5ad9dc tests/ECMInstallIconsTest/check_tree.cmake.in 6d14246b94bbfa801c497af92878cff9cb979184 tests/ECMInstallIconsTest/expected-tree/badly-named-files-test/hicolor/icon-theme.cache PRE-CREATION tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/icon-theme.cache PRE-CREATION tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/icon-theme.cache PRE-CREATION tests/ECMInstallIconsTest/expected-tree/single-file-test/hicolor/icon-theme.cache PRE-CREATION tests/ECMInstallIconsTest/expected-tree/themed-lang-test/oxygen/icon-theme.cache PRE-CREATION tests/ECMInstallIconsTest/expected-tree/themed-test/theme-name-2/icon-theme.cache PRE-CREATION tests/ECMInstallIconsTest/expected-tree/v1-icons/crystalsvg/icon-theme.cache PRE-CREATION tests/ECMInstallIconsTest/expected-tree/v1-icons/hicolor/icon-theme.cache PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125631/diff/ Testing ------- `make test` now reports 100% tests passed. Thanks, Alex Merry
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
