> On Nov. 4, 2015, 6:57 a.m., Martin Gräßlin wrote: > > Thanks. The approach looks sensible to me. I hope the warnings get read, > > though.
Well, until we've sorted out CMP0063, it'll be quite hard for anyone with a recent CMake to read any output. But I hope people read the output when they're writing the CMakeLists.txt files. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125935/#review87982 ----------------------------------------------------------- On Nov. 3, 2015, 6:39 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125935/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2015, 6:39 p.m.) > > > Review request for Extra Cmake Modules and Martin Gräßlin. > > > Repository: extra-cmake-modules > > > Description > ------- > > The XINPUT library is unlikely to be available on many systems, > including a lot of Linux distributions. This will warn developers in > advance by (a) not searching for XINPUT unless it was explicitly > requested, and (b) printing a warning if they do request it. > > > Diffs > ----- > > find-modules/FindXCB.cmake b2a800f73058382ee84f7d93132a96f8852b4aa7 > modules/ECMFindModuleHelpers.cmake 63cccb933334e0c392159abe161419d3f48b21f3 > > Diff: https://git.reviewboard.kde.org/r/125935/diff/ > > > Testing > ------- > > wacomtablet's kf5-port branch still configures, but with a warning. kwin > configures without a warning. Modified kwindowsystem to call > find_package(XCB), and that also configures without a warning. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
