-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126000/
-----------------------------------------------------------
(Updated Nov. 9, 2015, 12:35 a.m.)
Review request for Extra Cmake Modules.
Changes
-------
Fix problems with AUTOMOC with old interface.
Bugs: 346188
http://bugs.kde.org/show_bug.cgi?id=346188
Repository: extra-cmake-modules
Description
-------
Because the old implementation (accidentally) worked when you put the
ecm_create_qm_loader call in a different CMakeLists.txt file to the
target the file was added to, some projects did this.
This won't work with build-time-generated files, though, like moc files.
So this modifies the API of ecm_create_qm_loader (adding a keyword for
the catalog argument), and essentially behaves as before (without the
multithreading fix) if the new interface is not used.
BUG: 346188
Diffs (updated)
-----
modules/ECMPoQmTools.cmake 12bcf6b67c57dd456f078820f86c1e8365cb7c06
modules/ECMQmLoader.cpp.in 423d1c932ddcf3d98c94d2f67e73355129357768
tests/ECMPoQmToolsTest/CMakeLists.txt
76d801411b87987ac05de8dd99a0f37266ef6909
tests/ECMPoQmToolsTest/check.cmake.in
ab434d2e425ff57f323a196acc60e0e52c0abb10
tests/ECMPoQmToolsTest/check_conf.cmake.in
9ab02e72c4f5aa740c04116e824a54c61fe8bda8
tests/ECMPoQmToolsTest/tr_thread_test.cpp PRE-CREATION
tests/ECMPoQmToolsTest/tr_thread_test_module.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/126000/diff/
Testing
-------
Extended unit tests, which pass.
Thanks,
Alex Merry
_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem
