> On Sept. 17, 2015, 1:01 p.m., Alex Merry wrote: > > This change is a correct one to make, but I've slightly lost track of the > > kdelibs release policy. > > > > This patch isn't fixing an issue anyone is actually hitting, right? And > > it's not like qglobal.h in Qt 4 is going to have any significant changes > > made to it. So it's possible this doesn't pass the threshold of bug fixes > > for kdelibs, which is permanently frozen to some degree.
> This patch isn't fixing an issue anyone is actually hitting, right? I was going to say we had to do it downstream for FreeBSD because the oldest supported release can end up using clang with a very old libstdc++ without C++11 support, but since then I've managed to put all the required changes in our Qt package :-) - Raphael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125236/#review85550 ----------------------------------------------------------- On Sept. 15, 2015, 11:59 a.m., Raphael Kubo da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125236/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 11:59 a.m.) > > > Review request for Build System and kdelibs. > > > Repository: kdelibs > > > Description > ------- > > Backport upstream CMake commit de30173d ("Remove C compiler requirement > from FindQt4.cmake") from 2011 so that we check for symbols such as the > Q_WS_* ones with a C++ compiler instead of a C one. > > > Diffs > ----- > > cmake/modules/FindQt4.cmake e439a72f82c51758830b057b368407e11a6a541e > > Diff: https://git.reviewboard.kde.org/r/125236/diff/ > > > Testing > ------- > > Adding something C++-specific to qglobal.h (e.g. `#include <ciso646>`) > works and the right flags are still detected. > > > Thanks, > > Raphael Kubo da Costa > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
