----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126405/#review89709 -----------------------------------------------------------
Ship it! Looks good, reduces the output also on msvc. - Patrick Spendrin On Dez. 17, 2015, 7:39 nachm., Kevin Funk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126405/ > ----------------------------------------------------------- > > (Updated Dez. 17, 2015, 7:39 nachm.) > > > Review request for Extra Cmake Modules, Alex Merry and Hannah von Reth. > > > Repository: extra-cmake-modules > > > Description > ------- > > Example: > CMake Warning (dev) at > Z:/kderoot/share/ECM/kde-modules/KDEFrameworkCompilerSettings.cmake:50(elseif): > Policy CMP0054 is not set: Only interpret if() arguments as variables or > keywords when unquoted. Run "cmake --help-policy CMP0054" for policy > details. Use the cmake_policy command to set the policy and suppress this > warning. > > > Diffs > ----- > > kde-modules/KDECompilerSettings.cmake > 73d778255edca3d81ebc2e6b8e67b22896c81fef > kde-modules/KDEFrameworkCompilerSettings.cmake > e88c10d9cc6b5de59912e11de43555f056468cb5 > > Diff: https://git.reviewboard.kde.org/r/126405/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Funk > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
