> On Feb. 1, 2016, 3:15 p.m., Holger Kaelberer wrote: > > We default to "auto", which means in most cases "submodule", because > > something like a "system"-provided (read: packaged) qml-box2d does not yet > > exist in most distros. Defaulting to system would imho be fine if most > > systems would provide the dependency. > > > > It's not uncommon that git repos use submodules for dependencies that are > > populated at build-time. Or do we break some KDE policy here? > > > > Cf. also > > https://mail.kde.org/pipermail/gcompris-devel/2015-October/004375.html
You break most distros' policies (they enforce it by having build servers have no access to the network) and most user expectations (downloading at code at compile time is not something I want and I will instantly Ctrl-C if I catch it). It's better to say "dependency not found", and let the user choose between installing it from the distro if available, compiling it and installing it by hand, or setting `QML_BOX2D_MODULE=submodule`. - Nicolás ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126939/#review91867 ----------------------------------------------------------- On Jan. 31, 2016, 12:32 p.m., Sune Vuorela wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126939/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2016, 12:32 p.m.) > > > Review request for Build System and GCompris. > > > Repository: gcompris > > > Description > ------- > > I was negatively surprised to having a default build doing network traffic. > This is an attempt to make the default less surprising > > > Diffs > ----- > > CMakeLists.txt 371b6d3 > > Diff: https://git.reviewboard.kde.org/r/126939/diff/ > > > Testing > ------- > > a default setup now builds without networking > > > Thanks, > > Sune Vuorela > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
