----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127440/#review93823 -----------------------------------------------------------
Ship it! I don't remember what trouble there was with this but looks not needed indeed. - Martin Klapetek On March 20, 2016, 7:46 p.m., Stephen Kelly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127440/ > ----------------------------------------------------------- > > (Updated March 20, 2016, 7:46 p.m.) > > > Review request for Extra Cmake Modules, Alex Merry and Martin Klapetek. > > > Repository: extra-cmake-modules > > > Description > ------- > > The original review request doesn't say what concrete problem led to this > being added: https://git.reviewboard.kde.org/r/126368/ > > > QLoggingCategory has always included QDebug, so this has always been > superfluous. > > > Diffs > ----- > > modules/ECMQtDeclareLoggingCategory.cmake 3f7bb79 > modules/ECMQtDeclareLoggingCategory.h.in b59bc7a > > Diff: https://git.reviewboard.kde.org/r/127440/diff/ > > > Testing > ------- > > None. > > > Thanks, > > Stephen Kelly > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
