----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128231/#review96904 -----------------------------------------------------------
Isn't it much more common to name the guard after the header filename? - David Faure On June 20, 2016, 10:11 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128231/ > ----------------------------------------------------------- > > (Updated June 20, 2016, 10:11 a.m.) > > > Review request for Extra Cmake Modules. > > > Repository: extra-cmake-modules > > > Description > ------- > > The default generated guard is based on <category_name>_H . It's not > unreasnoble to have another header file in the same project with the > same name as the category name and thus same guard name. > > > Diffs > ----- > > modules/ECMQtDeclareLoggingCategory.cmake > c125949a46c4b83544413f23d5e04b2d8ea2c4cf > > Diff: https://git.reviewboard.kde.org/r/128231/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
