> On July 21, 2016, 1:55 p.m., David Faure wrote: > > modules/ECMQueryQmake.cmake, line 14 > > <https://git.reviewboard.kde.org/r/128488/diff/1/?file=472094#file472094line14> > > > > If query_qmake isn't public API, it's not what the cmakelists.txt is > > calling. So it looks like an internal error message surfacing up to the > > user. > > What should the user do when hitting this warning? (put qt5 qmake in > > PATH, right?). => I'd remove the mention of query_qmake() in the warning > > and explain more precisely what to do instead. > > > > And what should a developer do if they want to use ECM for qt4? (not > > use this file, I suppose, but if that file is used elsewhere in ECM, it's > > not really a choice, is it?)
Other than within this patch, it's only used by KDEInstallDirs, which is Qt5-only. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128488/#review97710 ----------------------------------------------------------- On July 20, 2016, 10:42 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128488/ > ----------------------------------------------------------- > > (Updated July 20, 2016, 10:42 a.m.) > > > Review request for Extra Cmake Modules, KDE Frameworks and David Faure. > > > Repository: extra-cmake-modules > > > Description > ------- > > Addresses its usage on systems where Qt5 isn't installed, it allows for > modules using it to decide what they should do. > > > Diffs > ----- > > modules/ECMQueryQmake.cmake 8f4cf17 > > Diff: https://git.reviewboard.kde.org/r/128488/diff/ > > > Testing > ------- > > Should fix this issue: > https://build.kde.org/job/extra-cmake-modules%20master%20latest-qt4/16/PLATFORM=Linux,compiler=gcc/console > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
