----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128531/#review97858 -----------------------------------------------------------
KF5DocToolsMacros.cmake (line 140) <https://git.reviewboard.kde.org/r/128531/#comment65943> Please use the cmake function to get the filename of a path, and then use that for checking (restricting the regex to ^man-etc$). - Pino Toscano On July 26, 2016, 8:54 p.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128531/ > ----------------------------------------------------------- > > (Updated July 26, 2016, 8:54 p.m.) > > > Review request for Build System, Documentation and Pino Toscano. > > > Repository: kdoctools > > > Description > ------- > > Remove man-*.docbook files from the list of files which are considered as > dependency for the manual and which are installed. > Manpages sources must be handled with kdoctools_create_manpage anyway, the > installed source docbook files for them were useless. > > > Diffs > ----- > > KF5DocToolsMacros.cmake e0a85b3 > > Diff: https://git.reviewboard.kde.org/r/128531/diff/ > > > Testing > ------- > > Tested with repositories which provides docbook for manpages and regular > manuals (kate, kde-baseapps/frameworks). > > > Thanks, > > Luigi Toscano > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
