-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129140/#review100029
-----------------------------------------------------------



I'll leave the decision up to you, but I think this should only be added if 
`peruse`'s presence in playground is simply temporary, and that it's currently 
planned to move to kde/kdegraphics or similar. There are a whole lot of modules 
in playground/base alone, so I want to be careful of how many of them get added 
to the default KF5 build.

If it's not planned to move to kde/kdegraphics, you could still add it as part 
of a commented module-set (probably in kf5-applications-build-include) to show 
off the playground git repositories. Something like:

    module-set playground-modules
        repository kde-projects
        
        # Uncomment the following line to build software programs that are 
still under development
        #use-modules peruse kio-mtp
    end module-set

- Michael Pyne


On Oct. 10, 2016, 11:46 a.m., Tomaz  Canabrava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129140/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 11:46 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> -------
> 
> Signed-off-by: Tomaz Canabrava <tcanabr...@kde.org>
> 
> 
> Diffs
> -----
> 
>   kf5-applications-build-include f53c0233ba46322829076db3437cf9c62a65ff8e 
> 
> Diff: https://git.reviewboard.kde.org/r/129140/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

Reply via email to