> On Oct. 15, 2016, 8:51 p.m., Michael Pyne wrote: > > I think at some point I will want to find a way to have the > > kf5-*-build-include files be a reduced set of modules nearly everyone > > agrees are essential, and then have a user's own desired module-sets be > > picked up based on a separate file, that way we don't have to add every KF5 > > and Plasma5 module into the sample KF5-based configuration. But that's > > neither here nor there... > > > > The changes make sense but I would recommend some differences. > > > > I think it would be better to have the repos that are currently in > > extragear or playground (but eventually destined for KF5) to be factored > > out into their own separate module-set. Once they enter KF5 they should be > > removed from kf5-frameworks-build-include since kdesrc-build will find them > > automatically, but if every such module is spread across multiple > > kf5-*-build-include files it will make that cleanup that much harder. > > > > The kamoso comment below is similar -- if we rely on manually adding repo > > names to kf5-*-build-include then many users will simply never build or > > test these repos.
kirigami is essential for two apps currently, one in kdebase-apps: peruse and discover, while 'purpose' only for kamoso. do you want me to split the commits? - Tomaz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129117/#review100026 ----------------------------------------------------------- On Oct. 10, 2016, 10:07 a.m., Tomaz Canabrava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129117/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 10:07 a.m.) > > > Review request for Build System. > > > Repository: kdesrc-build > > > Description > ------- > > Kirigami is now needed to run discover, so it should be build > Purpose is needed by at least kamoso. > > Signed-off-by: Tomaz Canabrava <tcanabr...@kde.org> > > Add Kamoso to the buildsystem. > > Kamoso was missing from kdegraphics. > > Signed-off-by: Tomaz Canabrava <tcanabr...@kde.org> > > > Diffs > ----- > > kf5-applications-build-include f53c0233ba46322829076db3437cf9c62a65ff8e > kf5-frameworks-build-include a88498e3248262d2e1fddacd726e1ef06a3ac1e4 > > Diff: https://git.reviewboard.kde.org/r/129117/diff/ > > > Testing > ------- > > > Thanks, > > Tomaz Canabrava > >
