-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128278/#review100235
-----------------------------------------------------------
There is a missing `-C` or an extra
`${CMAKE_CURRENT_SOURCE_DIR}/${_templateName}` in the lastest patch
- Maximiliano Curia
On June 24, 2016, 1:27 p.m., Scarlett Clark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128278/
> -----------------------------------------------------------
>
> (Updated June 24, 2016, 1:27 p.m.)
>
>
> Review request for Extra Cmake Modules, Sune Vuorela and Simon Wächter.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Cmake tar command does not allow for switches that fix umask and user/group
> inconsistancy which cause unreproducible builds. This patch takes the tar
> command used in kdevplatform that has all the required switches to make
> builds that use this macro reproducible.
>
>
> Diffs
> -----
>
> kde-modules/KDEPackageAppTemplates.cmake c0eb8b9
>
> Diff: https://git.reviewboard.kde.org/r/128278/diff/
>
>
> Testing
> -------
>
> Build and installed ECM and then rebuilt an affected project (
> plasma-framework ) which is now reproducible.
>
>
> Thanks,
>
> Scarlett Clark
>
>
