----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129316/#review100741 -----------------------------------------------------------
This adds a cmake module to do the right kind of checking (for inotify) for the platform: - on linux, check for the kernel subsystem / header - on freebsd, check for the port / header So it's still going to have knock-on effects (or subsequent reviews and changes) for consumers of inotify? The name FindLibinotify doesn't really make sense for the linux case (where it's not a library). Should it be named FindInotify instead? - Adriaan de Groot On Nov. 3, 2016, 7:30 a.m., Tobias Berner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129316/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2016, 7:30 a.m.) > > > Review request for Extra Cmake Modules, Adriaan de Groot, Gleb Popov, and > Raphael Kubo da Costa. > > > Repository: extra-cmake-modules > > > Description > ------- > > FreeBSD also has inotify. However it is a library and not a kernel subsystem. > > > With that change, targets checking for sys/inotify.h could switch from > something like > ``` > option(ENABLE_INOTIFY "Try to use inotify for directory monitoring" ON) > if(ENABLE_INOTIFY) > include(CheckIncludeFiles) > check_include_files(sys/inotify.h SYS_INOTIFY_H_FOUND) > set(HAVE_SYS_INOTIFY_H ${SYS_INOTIFY_H_FOUND}) > endif() > ``` > to > ``` > option(ENABLE_INOTIFY "Try to use inotify for directory monitoring" ON) > if(ENABLE_INOTIFY) > find_package(Libinotify) > set_package_properties(Libinotify PROPERTIES > PURPOSE > "Filesystem alteration notifications using inotify") > set(HAVE_SYS_INOTIFY_H ${LIBINOTIFY_FOUND}) > else() > set(HAVE_SYS_INOTIFY_H FALSE) > endif() > ``` > [from kcoreaddons], and append `${LIBINOTIFY_INCLUDE_DIRS}` to the > `include_directories`, aswell as `${LIBINOTIFY_LIBRARIES}` to the > link-libraires. > > > Diffs > ----- > > find-modules/FindLibinotify.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129316/diff/ > > > Testing > ------- > > Used in the unofficial KDE FreeBSD ports. > > > Thanks, > > Tobias Berner > >
