I did some negative testing, and from what I can see, 3.8 might well be OK for the ECM fork. My version depends on 3.9 (for example, there are some new constants defined by clang which I use), but I've no idea if this will ever be merged.
On 4 April 2017 at 19:08, Heiko Becker <[email protected]> wrote: > heikobecker added a comment. View Revision > <https://phabricator.kde.org/D5289> > > In D5289#99625 <https://phabricator.kde.org/D5289#99625>, @shaheed > <https://phabricator.kde.org/p/shaheed/> wrote: > > Fwiw, I think that a specific version check may not be needed. The original > code I wrote, which I assume Steve may have simply carried forward in the > cmake ecm logic, DID have a version check but only because the python > bindings were newish circa libclang 3.8. > > I'm certainly open to using ClangConfig.cmake and would even prefer it, > but I guess I'll wait for feedback from Steve about the version requirement. > > *REPOSITORY* > R240 Extra CMake Modules > > *REVISION DETAIL* > https://phabricator.kde.org/D5289 > > *To: *heikobecker, Frameworks, Build System, skelly, kfunk > *Cc: *rdieter, shaheed, kde-buildsystem, lbeltrame >
