kfunk added inline comments.
INLINE COMMENTS
> ECMGeneratePkgConfigFile.cmake:172
> if(EGPF_INSTALL)
> - set(ECM_PKGCONFIG_INSTALL_DIR "${EGPF_LIB_INSTALL_DIR}/pkgconfig" CACHE
> PATH "The directory where pkgconfig will be installed to.")
> + if(NOT CMAKE_SYSTEM_NAME matches "FreeBSD")
> + set(ECM_PKGCONFIG_INSTALL_DIR "${EGPF_LIB_INSTALL_DIR}/pkgconfig"
> CACHE PATH "The directory where pkgconfig will be installed to.")
`matches` -> `MATCHES` -- I'm surprised that actually works as-is.
Also: Why not `if (CMAKE_SYSTEM_NAME MATCHES ...)` and switch the bodies inside
the if & else branch to simplify?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5766
To: tcberner, #freebsd, apol
Cc: kfunk, #frameworks, #build_system
