rjvbb marked an inline comment as done.
rjvbb added a comment.
> I'll hope to find some time to test on Window, wouldn't want this to be
merged before that.
Should we read "not to be merged before *you* have tested it"? I have nothing
against that, esp. if you also find the exact value to use for the MSC_VERSION
test ;)
INLINE COMMENTS
> kfunk wrote in KDECompilerSettings.cmake:226
> `MSVC_VERSION GREATER 1900` is sufficient. No need for `${...}`
Will fix that before committing anything.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5865
To: rjvbb, #frameworks, #build_system, cgilles
Cc: kfunk
