apol added inline comments.

INLINE COMMENTS

> sitter wrote in ECMFindQMLModule.cmake.in:30
> Not sure if we have a common practice for this, but I am thinking this needs 
> to have a `find_program()` and give suitable output if qmlplugindump itself 
> cannot be found. Pointing the user towards qtdeclarative being needed to 
> check qml dependencies.

Doing find_program for now. The right fix would be to change Qt to export the 
`qmlplugindump` target.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D7094

To: apol, #build_system, #frameworks, sitter
Cc: dfaure, aacid

Reply via email to