shaheed added inline comments. INLINE COMMENTS
> turbov wrote in FindPythonModuleGeneration.cmake:212 > What distribution is this? Why only 3.8 and 3.9?? Why not 4.0 or 5.0??? > > I've just checked Ubuntu 14.04 (Clang 3.3 to 3.9 available) and 17.10 (up to > 5.0 available)... installing `libclang-X.Y` (or `libclang-X.Y-devel` > obviously) always bring `libclang.so` library (which is of cause a symlink to > a versioned name), but it always here... Also, I've checked CentOS 7 w/ DTS7 > <https://www.softwarecollections.org/en/scls/rhscl/devtoolset-7/> (Clang 4.0) > -- same here... > > so the question is "why to search a versioned name?" -- I don't know any > distro where `libclang.so` is not available... do you? The original code had a minimum requirement of either 3.8 or 3.9 (I don't recall exactly, but the code here implies 3.8 is the minimum). Newer versions are fine. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8780 To: turbov Cc: cgiboudeaux, shaheed, #frameworks, #build_system
