davidk added inline comments.

INLINE COMMENTS

> FindSeccomp.cmake:50-55
> +if(CMAKE_VERSION VERSION_LESS 2.8.12)
> +    message(FATAL_ERROR "CMake 2.8.12 is required by FindSeccomp.cmake")
> +endif()
> +if(CMAKE_MINIMUM_REQUIRED_VERSION VERSION_LESS 2.8.12)
> +    message(AUTHOR_WARNING "Your project should require at least CMake 
> 2.8.12 to use FindSeccomp.cmake")
> +endif()

I'm not sure about this. @graesslin  is this nessecarry? Most find-modules 
don't check for the CMake version, and we don't do anything special here.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8998

To: davidk, graesslin
Cc: #frameworks, #build_system

Reply via email to