habacker added a comment.
- doc in file header is missing
- test case is missing
INLINE COMMENTS
> ECMQtDeclareLoggingCategory.cmake:68
> set(options)
> - set(oneValueArgs HEADER IDENTIFIER CATEGORY_NAME DEFAULT_SEVERITY)
> + set(oneValueArgs HEADER IDENTIFIER CATEGORY_NAME DEFAULT_SEVERITY
> CATEGORY_INSTALL_FILENAME CATEGORY_DESCRIPTION)
> set(multiValueArgs)
may be better using shorter names like INSTALL_FILENAME, DESTINATION or
FILENAME
and DESCRIPTION instead of CATEGORY_DESCRIPTION. because we are declaring a
logging category
> ECMQtDeclareLoggingCategory.cmake:138
> + if (ARG_CATEGORY_INSTALL_FILENAME)
> + set(CAT_DESCRIPTION)
> + if (ARG_CATEGORY_DESCRIPTION)
Using ${PROJECT_NAME} if empty ?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9446
To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt
Cc: ltoscano, kde-frameworks-devel, kde-buildsystem, habacker, michaelh,
ngraham, bruns
