cgiboudeaux added inline comments.
INLINE COMMENTS
> FindPythonModuleGeneration.cmake:39
> #
>
>
> #=============================================================================
KDE_INSTALL_USE_PYTHON${version}_SYS_PATHS shall be added to the doc
> FindPythonModuleGeneration.cmake:206-207
> + if(KDE_INSTALL_PYTHON${pyversion}DIR)
> + # Use dir from command line
> +
> + elseif(KDE_INSTALL_USE_PYTHON${pyversion}_SYS_PATHS)
This "if" is not needed if nothing happens.
> FindPythonModuleGeneration.cmake:208
> +
> + elseif(KDE_INSTALL_USE_PYTHON${pyversion}_SYS_PATHS)
> + if (NOT GPB_PYTHON${pyversion}_SITEARCH)
if(KDE_INSTALL_USE_PYTHON${pyversion}_SYS_PATHS)
if the option is set, KDE_INSTALL_PYTHON${pyversion}DIR can be safely ignored
> FindPythonModuleGeneration.cmake:209
> + elseif(KDE_INSTALL_USE_PYTHON${pyversion}_SYS_PATHS)
> + if (NOT GPB_PYTHON${pyversion}_SITEARCH)
> + execute_process (
This variable is not defined anywhere, this if can be removed.
> FindPythonModuleGeneration.cmake:216
> +
> + else()
> + set(KDE_INSTALL_PYTHON${pyversion}DIR
> lib/python${pyversion${pyversion}_maj_min}/site-packages)
elseif(NOT DEFINED KDE_INSTALL_PYTHON${pyversion}DIR)
> FindPythonModuleGeneration.cmake:217
> + else()
> + set(KDE_INSTALL_PYTHON${pyversion}DIR
> lib/python${pyversion${pyversion}_maj_min}/site-packages)
> + endif()
"lib" is hardcoded. it shouldn't.
the commit log also mentions the patch uses dist-packages on Debian and its
forks. This is not the case here.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D15070
To: bruns, #frameworks
Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh,
ngraham, bruns
