vkrause added a comment.
In D19005#414313 <https://phabricator.kde.org/D19005#414313>, @apol wrote: > In D19005#412258 <https://phabricator.kde.org/D19005#412258>, @vkrause wrote: > > > Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"? > > > no, the value is coming from the cache, so that's the one we're setting. What this patch tries to make sure is that we don't forward an empty value (resetting a proper variable to ""). ah, that makes more sense, no idea why that seemed to break things here then though REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19005 To: apol, #frameworks, vkrause Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
