kossebau added a comment.

  Any chance this could not be done by abusing KDECMakeSettings.cmake as 
injection vector? I know you are just following the example of what was done 
for appstreamcli, but IMHO this has already been a bad hack, screwing over the 
fine granular design of all the ECM modules trying to keep aspects separate. 
And yes, by the price of the overhead with more explicit module includes, but 
it's like that. Or we should just screw it and put everything in one big 
"KDEECMEverythingEvenKitchenSink.cmake" ;) And yes, one possible would like to 
have such a generic wrapper module in any case, for quick prototyping. But the 
individual modules should stay focussed.
  
  The docs of KDECMakeSettings say: "Changes various CMake settings to what the 
KDE community views as more sensible defaults."
  Thus adding automatic tests or macros for tests using external tools would 
not in the scope of this very module.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19996

To: vkrause
Cc: kossebau, winterz, knauss, cgiboudeaux, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, bencreasy, michaelh, ngraham, bruns

Reply via email to