thomasfischer updated this revision to Diff 68072.
thomasfischer added a comment.
I rewrote the patch to address the comments:
1. Setting `ECM_SOURCE_UNDER_VERSION_CONTROL` has been refactored to set
variable `ECM_SOURCE_VERSION_CONTROL_WHICH` as well to determine which of three
known VCSes are used. `ECM_SOURCE_VERSION_CONTROL_WHICH` contains a string like
"git" or "svn".
2. The more expensive check where an external program ("git") has to be run
got refactored into a macro (`ecm_source_version_control_stat`). Support for
Subversion, Mercurial, and Bazaar got removed. Messages will be printed to show
the status of the analysis. It is a macro, not a function, to have changes to
variables like `ECM_SOURCE_VERSION_CONTROL_BRANCH` visible outside of the
function.
To clarify `ECM_SOURCE_VERSION_CONTROL_COMMIT_COUNT`: it counts the number of
commits in direct line of succession from the repository's initialization to
the current commit. It does not include commits in other branches. Basically
the number of commits listed in a plain `git log`. The commit count gives a
quick indication of the progress of a repository (or branch) without requiring
to look up the repo's commit messages or hashes.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24641?vs=67922&id=68072
REVISION DETAIL
https://phabricator.kde.org/D24641
AFFECTED FILES
modules/ECMSourceVersionControl.cmake
To: thomasfischer, sitter, kossebau
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,
michaelh, ngraham, bruns
