patrickelectric added a comment.
@apol I did update the commit body to explain why. For the text I used https://regex101.com with the icon in the commit body and printing the variables of CMAKE_MATCH_1 and CMAKE_MATCH_2 Let me know if you agree with this to land the patch, this is necessary to continue D26752 <https://phabricator.kde.org/D26752> REPOSITORY R240 Extra CMake Modules BRANCH sc_appicon REVISION DETAIL https://phabricator.kde.org/D26751 To: patrickelectric, tcanabrava, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
