On Sat, Aug 26, 2017 at 10:17 PM, Ben Cooksley <bcooks...@kde.org> wrote: > On Sun, Aug 27, 2017 at 1:15 AM, Adriaan de Groot <gr...@kde.org> wrote: >> On Saturday 26 August 2017 23:06:29 Ben Cooksley wrote: >>> > Not from `arc` which is a wholly different problem I suppose. But yes, >>> > it's kinda manageable, just not all that convenient. The tricky bit is >>> > really figuring out who to set as reviewer to begin with. >>> >>> Ideally you wouldn't need to set a reviewer at all - it should be >>> handled for you automatically. >> >> Would it make sense to add this information -- possibly just as a comment, >> but >> it'd be better as real data -- in the .arcconfig of each repo? That would >> require work from Phab upstream to do right, but it would be useful so that >> individual repo's can say >> >> reviewers: [ tom, dick, harry ] >> >> or whatever the right JSON formatting is for that. > > That would potentially be another way of doing it yes. However if > someone isn't using Arcanist to make their submission then they won't > be affected by this (they could manually check it I guess though).
I rather liked this bit of reviewboard TBH, alas, won't fix for phab: https://secure.phabricator.com/T6927 (also Owners is actually way more versatile and works for both arc and manual diff upload, so I think I like that actually better and so should everyone else ;)) HS