----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5775/ -----------------------------------------------------------
(Updated 2010-11-06 22:35:06.086790) Review request for kdelibs. Changes ------- Sorry for not looking more carefully. I think the reference counter was done by QSharedDataPointer. Instead, include your comment. I know it is trivial code for most of you, but not for everybody. :-( Summary (updated) ------- As I do not know if that kind of patches are allowed in the freeze period, I ask for them together. I'll submit them individually. 1. ktimezone. Include a comment with the real use of refCount. 2. klocale_kde. From 469 queries to paths.end() to 1 (from 0.01% to 0% in callgrind) 3. netsupp. Remove a memory leak. 4. ksharedDataCache. Change the obsolete usleep (since 2001 or before) to nanosleep. Diffs (updated) ----- /trunk/KDE/kdelibs/kdecore/date/ktimezone.cpp 1193582 /trunk/KDE/kdelibs/kdecore/localization/klocale_kde.cpp 1193582 /trunk/KDE/kdelibs/kdecore/network/netsupp.cpp 1193582 /trunk/KDE/kdelibs/kdecore/util/kshareddatacache.cpp 1193582 Diff: http://svn.reviewboard.kde.org/r/5775/diff Testing ------- No regressions in the unit tests. Working with them. Thanks, Jaime
