----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5797/#review8547 -----------------------------------------------------------
Please resubmit on the solid group. Thanks in advance. - Kevin On 2010-11-08 07:11:53, Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5797/ > ----------------------------------------------------------- > > (Updated 2010-11-08 07:11:53) > > > Review request for kdelibs. > > > Summary > ------- > > The attached patch does the following: > > 1.) Remove the call to allDevices() from UDisksManager's ctor. Instead a new > private method is added to properly initialize the devices list cache before > use. > > 2.) Remove the 'result' variable from UDisksManager::allDevices since it is > unnecessary and m_deviceCache can be used directly. > > 3.) Other minor namespace (foreach -> Q_FOREACH) and macro-performance (moving > the call for propertyCount() out of the for loop. > > Note that the Bug number above is only mentioned as a reference to point out > the origins of the attached patches... > > > This addresses bug 253039. > https://bugs.kde.org/show_bug.cgi?id=253039 > > > Diffs > ----- > > trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksdevice.cpp 1192709 > trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksmanager.h 1192709 > trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksmanager.cpp 1192709 > > Diff: http://svn.reviewboard.kde.org/r/5797/diff > > > Testing > ------- > > > Thanks, > > Dawit > >
