----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5795/#review8548 -----------------------------------------------------------
trunk/KDE/kdelibs/kate/plugins/exporter/htmlexporter.cpp <http://svn.reviewboard.kde.org/r/5795/#comment8926> Shouldn't this be something like ? QLatin1Literal("color:") + attrib->foreground().color().name() + QLatin1Char(';') : QString() ) In general in this patch I think you should be using QLatin1Literal instead of QLatin1String in most places. - Stephen On 2010-11-08 07:03:57, Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5795/ > ----------------------------------------------------------- > > (Updated 2010-11-08 07:03:57) > > > Review request for kdelibs. > > > Summary > ------- > > The attached patch makes it possible to compile kdelibs using the global Qt > defines that improve the performance of QString concatenation, i.e. > QT_USE_FAST_CONCATENATION and QT_USE_FAST_OPERATOR. For more details about > faster QString concatenation, see "More Efficient String Construction" > section of QString's documentation. > > > Diffs > ----- > > trunk/KDE/kdelibs/kate/plugins/exporter/htmlexporter.cpp 1193961 > trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp 1193961 > trunk/KDE/kdelibs/kdewebkit/kwebpluginfactory.cpp 1193961 > trunk/KDE/kdelibs/khtml/ecma/kjs_scriptable.cpp 1193961 > trunk/KDE/kdelibs/khtml/ecma/kjs_scriptable.cpp 1193961 > trunk/KDE/kdelibs/knewstuff/knewstuff3/core/cache.cpp 1193961 > trunk/KDE/kdelibs/plasma/datacontainer.cpp 1193961 > trunk/KDE/kdelibs/plasma/widgets/declarativewidget.cpp 1193961 > > Diff: http://svn.reviewboard.kde.org/r/5795/diff > > > Testing > ------- > > > Thanks, > > Dawit > >
