----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4927/#review8357 -----------------------------------------------------------
For the record I too share David's concern with nested event loops... Also please try to use QL1S macro defined in kcookiejar for all literal string you pass to QString... /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp <http://svn.reviewboard.kde.org/r/4927/#comment8638> isn't this supposed to be "!wallet->readMap"... ? /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp <http://svn.reviewboard.kde.org/r/4927/#comment9365> This can be const... /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp <http://svn.reviewboard.kde.org/r/4927/#comment9364> All the variables here can be made const as well... /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.h <http://svn.reviewboard.kde.org/r/4927/#comment8637> Is this flag really necessary now ? Since you have a new QTimer, why not simply check the the validity and state of that tmer variable instead ? /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp <http://svn.reviewboard.kde.org/r/4927/#comment8636> this can be made const... - Dawit On 2010-10-26 01:24:01, José Millán Soto wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/4927/ > ----------------------------------------------------------- > > (Updated 2010-10-26 01:24:01) > > > Review request for kdelibs. > > > Summary > ------- > > Currently cookies are stored in a plain text file. This patch allows > KCookieJar to store the cookies securely using KWallet. > > The main problem I had writing this patch was that when a web page is > requested, KIO ask for the cookies to kded using dbus. In the first > implementations that I wrote, if the user took too long to open the wallet, > KIO received a dbus timeout. > > To prevent this, if it takes more than 10 seconds to open the wallet, the web > page will be requested without sending the cookies (or sending the available > cookies if there's still the plain text cookie file). If the wallet is opened > after that, the cookies stored in the wallet will be available since then. > > Because of this, the feature is disabled by default. > > > Diffs > ----- > > /trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiespolicies.cpp 1189829 > /trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiespoliciesdlg.ui > 1189829 > /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.h 1189787 > /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp 1189787 > /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.h 1189787 > /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp 1189787 > > Diff: http://svn.reviewboard.kde.org/r/4927/diff > > > Testing > ------- > > > Thanks, > > José > >
