----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6177/#review9361 -----------------------------------------------------------
I know. I think you misunderstood my reply. Let me clarify: there are defaults, and defaults :-) The "initial default" is the one that is used when the user has never tweaked any paths. That one comes from QDesktopServices. The "restored default" is the one that the "Defaults" button sets as the new value. That one comes from the kcm, lines 142-148. And my point is that these two "defaults" should match, otherwise things get very confusing: when the user presses the "Defaults" button he could get different folder names even if he/she didn't change any values ever! That's not the way people expect the "Defaults" button to work, it's suppose to restore "factory settings", aka "initial defaults". How to make these two defaults match is tricky, given that QDesktopServices offers us no API for doing so. So one would need per-platform "reset" code. But at least the current code (with untranslated strings) matches the QDesktopServices "initial defaults" on X11, while your change makes things worse by making the initial and restored defaults not match on X11 anymore. - David On 2010-12-21 14:18:35, Burkhard Lück wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6177/ > ----------------------------------------------------------- > > (Updated 2010-12-21 14:18:35) > > > Review request for kdelibs and David Faure. > > > Summary > ------- > > Using the Defaults button in the desktoppaths kcm resets all folders to the > default values, > but is currently using the untranslated strings in branch and trunk. > > Adding some i18n() calls resets the values to the translated strings for the > folders. > > > Diffs > ----- > > /branches/KDE/4.5/kdebase/workspace/kcontrol/desktoppaths/globalpaths.cpp > 1208322 > > Diff: http://svn.reviewboard.kde.org/r/6177/diff > > > Testing > ------- > > > Thanks, > > Burkhard > >
