----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6183/#review9527 -----------------------------------------------------------
trunk/KDE/kdelibs/kdewebkit/kwebpage.cpp <http://svn.reviewboard.kde.org/r/6183/#comment10529> I studied a bit the testing sites you gave me. I noticed that the download diff link in reviewboard does not work well with rekonq and konqueror (filename info NOT used). If I understood things well, the content-disposition header should be checked for filenames also having the "inline" value. So, something like: if(value.startsWith(QL1S("attachment"),...) || value.startsWith(QL1S("inline")...) I tested on rekonq code and it seems working. - Andrea On 2011-01-05 06:21:31, Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6183/ > ----------------------------------------------------------- > > (Updated 2011-01-05 06:21:31) > > > Review request for kdelibs and Andrea Diamantini. > > > Summary > ------- > > The attached patch fixes a long standing issue in the KIO-QNAM class where > actions that require putting an ioslave on hold currently do not work. In > kdewebkit, which uses this integration class, such actions always occur when > you click on a link that cannot be directly handled by the browsing engine. > For example, clicking on a link that points to a PDF link. Even worse is when > the link you click on results in an http POST which returns content. In such > cases, apps that rely on kdewebkit and hence the KIO-QNAM bridge class have > no way of putting an ioslave on hold as stated in KIO::get's documentation in > order to properly deal with content types they do not support. > > The attached patch along with another pending against kio_http, > http://reviewboard.kde.org/r/6182/ , remedies this issue by adding a means to > put replies on hold and fixing the downloadResponse slot in KWebPage to do > the right thing. > > > Diffs > ----- > > trunk/KDE/kdelibs/kdewebkit/ISSUES 1211858 > trunk/KDE/kdelibs/kdewebkit/ISSUES 1211858 > trunk/KDE/kdelibs/kdewebkit/kwebpage.h 1211858 > trunk/KDE/kdelibs/kdewebkit/kwebpage.cpp 1211858 > trunk/KDE/kdelibs/kio/kio/accessmanager.h 1211858 > trunk/KDE/kdelibs/kio/kio/accessmanager.cpp 1211858 > trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.h 1211858 > trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.cpp 1211858 > > Diff: http://svn.reviewboard.kde.org/r/6183/diff > > > Testing > ------- > > > Thanks, > > Dawit > >
