----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100516/#review1324 -----------------------------------------------------------
kioslave/http/http.cpp <http://git.reviewboard.kde.org/r/100516/#comment1096> Hmm, yeah, doesn't this make this all useless, if we end up making a QByteArray with the whole data in it anyway? I thought the whole point was for kio_http to read in chunks and send along the way, rather than read it all upfront. - David On Feb. 9, 2011, 1:28 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100516/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2011, 1:28 a.m.) > > > Review request for kdelibs. > > > Summary > ------- > > The attached patch is the first portion a set of patches to make uploading > data through HTTP more efficient without affecting the existing > implementation. Right now the amount of memory consumed when uploading large > files through http or webdav is really not acceptable because only a > QByteArray based API is available. That means if you want to upload a file of > say 50 or 100 MB to a server, then you have to read the entire thing first > before you can call KIO::http_post! > > > This addresses bug 34578. > http://bugs.kde.org/show_bug.cgi?id=34578 > > > Diffs > ----- > > kio/kio/job_p.h daac895 > kio/kio/jobclasses.h e9bd191 > kioslave/http/http.h be08d7b > kioslave/http/http.cpp 187e3c7 > kio/kio/accessmanager.cpp 722203f > kio/kio/job.h 632dfc8 > kio/kio/job.cpp 7d4a849 > > Diff: http://git.reviewboard.kde.org/r/100516/diff > > > Testing > ------- > > Used by changing kdewebkit to use the new API. > > > Thanks, > > Dawit > >
