> On March 26, 2011, 1:20 p.m., Alex Merry wrote: > > Do we still want this? We now have QScopedPointer, but it doesn't do quite > > what this does (it doesn't watch for QObjects being deleted).
Imo this should not go into kdelibs, as QPointer is notoriously slow and it's advised to use QWeakPointer instead. The patch as-is seems more appropriate for legacy systems. - Milian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/955/#review10028 ----------------------------------------------------------- On July 8, 2009, 10:12 a.m., David Jarvie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/955/ > ----------------------------------------------------------- > > (Updated July 8, 2009, 10:12 a.m.) > > > Review request for kdelibs. > > > Summary > ------- > > This template class is inherited from QPointer, and provides the additional > feature that on destruction it deletes the QObject whose pointer it contains. > > The motivation for adding this class is to deal with the issue described in > http://www.kdedevelopers.org/node/3919, whereby if a modal dialog is open > when an application is told to quit, the dialog will be deleted by its > parent, usually resulting in a crash due to double deletion of the dialog, or > due to accessing the dangling pointer to the dialog. > > This class is required by several applications in kdepim, and other modules > would also benefit by using it. > > A unit test will be provided if the class is approved. > > > Diffs > ----- > > /trunk/KDE/kdelibs/kdecore/util/kautopointer.h PRE-CREATION > > Diff: http://svn.reviewboard.kde.org/r/955/diff > > > Testing > ------- > > Works successfully in KAlarm. > > > Thanks, > > David > >
