----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100958/#review2213 -----------------------------------------------------------
Ship it! This looks good, ship it. - Jeremy Paul On March 27, 2011, 3:50 p.m., Matthias Fuchs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100958/ > ----------------------------------------------------------- > > (Updated March 27, 2011, 3:50 p.m.) > > > Review request for kdelibs and Frederik Gladhorn. > > > Summary > ------- > > * AtticaProvider also changes the cachedEntry in (!) the cache and it does > that for Installed and for Updateable entries. > The later is important, since sometimes updates are not done. > * Installation only stores updateReleaseDate if it is valid. > > > This addresses bug 256473. > http://bugs.kde.org/show_bug.cgi?id=256473 > > > Diffs > ----- > > knewstuff/knewstuff3/attica/atticaprovider.cpp 33e47ce > knewstuff/knewstuff3/core/installation.cpp be4ba69 > > Diff: http://git.reviewboard.kde.org/r/100958/diff > > > Testing > ------- > > Tested with the comic plasmoid. > > > Thanks, > > Matthias > >
