----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100960/#review2214 -----------------------------------------------------------
Ship it! This looks good. Ship it! - Jeremy Paul On March 27, 2011, 4:45 p.m., Matthias Fuchs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100960/ > ----------------------------------------------------------- > > (Updated March 27, 2011, 4:45 p.m.) > > > Review request for kdelibs and Frederik Gladhorn. > > > Summary > ------- > > Thus insuring that the cache is always consistent. > This way it can't happen, that e.g. DownloadManager updates some > KNS3::Entries and a call to DownloadWidget later on would overwrite the > updated ones as updateable. > > > Diffs > ----- > > knewstuff/knewstuff3/core/cache.h 5b0b60e > knewstuff/knewstuff3/core/cache.cpp 53aa55e > knewstuff/knewstuff3/core/engine.h 5aa7449 > knewstuff/knewstuff3/core/engine.cpp 1017628 > > Diff: http://git.reviewboard.kde.org/r/100960/diff > > > Testing > ------- > > Tested with the patch in https://git.reviewboard.kde.org/r/100958/ since that > fixes updateing. > > Test case: > Implemented auto-updating for the comic plamsoid. > After some updates happen the user clicks the get more button to install an > additional comic. In the old behaviour the comic would show up as not > installed after restarting, as the cache was not shared [1]. With the new > behaviour any updated comic will show up as installed and the newly installed > comic will also show up as installed. > > [1] Here it only depended which cache was written last to the disk. So either > all comics would still show up as updatedable or the one comic would show up > as not installed. > > > Thanks, > > Matthias > >
