----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101013/#review2681 -----------------------------------------------------------
Ship it! No problem, then please commit as is. - Christoph On April 2, 2011, 11:47 p.m., Parker Coates wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101013/ > ----------------------------------------------------------- > > (Updated April 2, 2011, 11:47 p.m.) > > > Review request for kdelibs. > > > Summary > ------- > > This patch attempts to improve the usefulness and usability of KFileDialog's > filter field when in Opening mode. > > Firstly, if the filter text isn't: * the display name of one of the filters > passed to the dialog or > * one or more space separated mimetype > specifiers (containing a '/') or > * one or more space separated file globs > (containing '*', '?' or "[.*]") > we convert the text to a glob by prepending and appending asterisks. This > lets the user enter a piece of text (without having to know any glob > patterns) and see only the files whose names contain that text, much the same > as they would when filtering in Dolphin. > > Secondly, the filtering updates on the fly as the filter text is typed. > Previously, the filtering updated only when Return was pressed, which differs > from the behaviour of most of KDE's other filter boxes. The old behaviour is > especially confusing when one clicks the small clear button embedded in the > combobox, because it clears the box, but the filtering is unchanged until the > user goes to the keyboard to press enter. > > > This addresses bug 142900. > http://bugs.kde.org/show_bug.cgi?id=142900 > > > Diffs > ----- > > kfile/kfilewidget.cpp 9b8cdeb > > Diff: http://git.reviewboard.kde.org/r/101013/diff > > > Testing > ------- > > I've played around with it a fair bit and it seems to work fine. I've never > really worked with this code before, so if I'm doing something silly please > let me know. > > > Thanks, > > Parker > >
