----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101149/#review2733 -----------------------------------------------------------
kioslave/ftp/ftp.cpp <http://git.reviewboard.kde.org/r/101149/#comment2400> If m_size is UnknownSize and the file is less than 1024 bytes, this code is going to hit the timeout, waiting for data to come in, that will never come in. I think that once waitForReadyRead was called once, the loop should break (after peeking, of course), if m_size==Unknown. kioslave/ftp/ftp.cpp <http://git.reviewboard.kde.org/r/101149/#comment2399> Are you sure that peek() is cumulative? I.e. that peek(100) + peek(100) doesn't give you the same data twice? I thought it would, since it "rewinds" after giving you the data. - David On April 18, 2011, 8:12 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101149/ > ----------------------------------------------------------- > > (Updated April 18, 2011, 8:12 p.m.) > > > Review request for kdelibs and David Faure. > > > Summary > ------- > > The attached patch changes the ftpGet function such that it emits the > mime-type of the content it is about to read, before starting to read it. > That way kio_ftp will work correctly if and when it is put on hold to be > reused from another application. Note that the patch uses QIODevice::peek to > achieve this goal. > > > Diffs > ----- > > kioslave/ftp/ftp.h 9814c10 > kioslave/ftp/ftp.cpp 64f43d8 > > Diff: http://git.reviewboard.kde.org/r/101149/diff > > > Testing > ------- > > > Thanks, > > Dawit > >
