----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101153/#review2805 -----------------------------------------------------------
This review has been submitted with commit 98a285a65665d42f45e9460f5b150cc84c0e9b86 by Dawit Alemayehu. - Commit On April 21, 2011, 2:50 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101153/ > ----------------------------------------------------------- > > (Updated April 21, 2011, 2:50 a.m.) > > > Review request for kdelibs and David Faure. > > > Summary > ------- > > This patch completely removes the automatic restoration of the user name from > the original url to the redirection url at the job level. Even though I tried > to lookup why this was done a long time ago, I have not been able to decipher > the reason behind it. I could only guess that it was probably done as a > workaround for the deficiencies of some unknown ioslave that was not doing > the right thing when constructing the redirection url. > > Unfortunately this has now come in full circle to cause problems when > attempting to fix kio_ftp's login related bug reports. Namely I wanted to fix > the problem where the user typed a username as part of the ftp url and later > on either changed it or choose to login anonymously when prompted with a > password dialog. Right now the client never gets updated even when the user > chose to use a different username in the password dialog. IOW, the username > reflected in the typed-in url is different from the one the user used to > login. You can guess what happens when the user then clicks on a folder or > file after logging in. > > The process I chose to use to update the client is to cause a redirection and > that works fine so long as the redirection url contains a proper username. > Otherwise, the redirection handling slots in KIO::Job automatically re-insert > the username from the old url into the new redirection url. > > > Diffs > ----- > > kio/kio/job.cpp 004b4c9 > > Diff: http://git.reviewboard.kde.org/r/101153/diff > > > Testing > ------- > > > Thanks, > > Dawit > >
