----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101200/#review2850 -----------------------------------------------------------
Ship it! Hi Dario, Thanks for the patches. Here, I think the strings should say "fixed ... in version %1" rather than "fixed ... in %1". Other than that, it looks fine. - George On April 23, 2011, 12:27 p.m., Darío Andrés Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101200/ > ----------------------------------------------------------- > > (Updated April 23, 2011, 12:27 p.m.) > > > Review request for KDE Runtime and George Kiagiadakis. > > > Summary > ------- > > Use the "Version Fixed In" bugzilla field if it is available > > > Diffs > ----- > > drkonqi/reportassistantpages_bugzilla_duplicates.cpp a8a7fd0 > > Diff: http://git.reviewboard.kde.org/r/101200/diff > > > Testing > ------- > > The version fixed in is shown, however, due to some bugzilla limitation the > version numbers lack the dots (ex. "4.7.0" is shown as "4 7 0"). > > > Thanks, > > Darío Andrés > >
