----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/758/#review10092 -----------------------------------------------------------
trunk/KDE/kdelibs/kfile/kdirselectdialog.cpp <http://svn.reviewboard.kde.org/r/758/#comment11341> Switch order of initialization trunk/KDE/kdelibs/kfile/kdirselectdialog.cpp <http://svn.reviewboard.kde.org/r/758/#comment11342> Q_UNUSED(index) - Sergio On Sept. 5, 2010, 6:05 a.m., Raphael Kubo da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/758/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2010, 6:05 a.m.) > > > Review request for kdelibs. > > > Summary > ------- > > Currently, there is no way to resize the places view in a KDirSelectDialog. > Sometimes the default width is too small, and I can't see the directory names. > > Most of the code in this patch was taken from KFileWidget - a QSplitter is > inserted between the places view and the directory tree view, its width is > read/written using KConfigGroup and it's not automatically resized when the > whole dialog is resized. > > The drawback is that modifications to code in KFileWidget may require > identical modifications to KDirSelectDialog too. Perhaps the best option > would be to refactor this functionality somewhere else, but the work required > would be much bigger. > > > This addresses bug 249476. > https://bugs.kde.org/show_bug.cgi?id=249476 > > > Diffs > ----- > > trunk/KDE/kdelibs/kfile/kdirselectdialog.h 1171225 > trunk/KDE/kdelibs/kfile/kdirselectdialog.cpp 1171762 > > Diff: http://svn.reviewboard.kde.org/r/758/diff > > > Testing > ------- > > Both Ark (in its Extraction Dialog) and Plasma's Desktop Settings (when > adding a folder for slideshow wallpapers) now have a QSplitter that works as > expected. > > > Thanks, > > Raphael > >
