> On May 5, 2011, 8:36 p.m., Christoph Feck wrote: > > kdialog/kdialog.cpp, line 378 > > <http://git.reviewboard.kde.org/r/101282/diff/2/?file=16137#file16137line378> > > > > Could you add the icon argument to this fallback call, too? See API > > docs for KPassivePopup.
KPassivePopup requires a QPixmap, so I need to search the icon, load the correct size and everything by myself? Loading wouldn’t be the problem but choosing the correct path. Somehow with xdg stuff but, hmm… - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101282/#review3137 ----------------------------------------------------------- On May 5, 2011, 3:57 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101282/ > ----------------------------------------------------------- > > (Updated May 5, 2011, 3:57 p.m.) > > > Review request for KDE Base Apps. > > > Summary > ------- > > Since I use kdialog a lot, I wanted it to be able to set an icon for passive > Plasma notifications as well. > I saw that the icon was hardcoded to dialog-information and tried to enable > it to parse the --icon command line argument and pass it to the dbus call > that triggers the notification. > I could not test the patch however, since I do not (yet) have a full > development environment or its dependencies, and I do not even know if this > is the right approach, but I hope you can have a look at it. > > > Diffs > ----- > > kdialog/kdialog.cpp b80ad9a > > Diff: http://git.reviewboard.kde.org/r/101282/diff > > > Testing > ------- > > > Thanks, > > Kai Uwe > >
