----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101282/ -----------------------------------------------------------
(Updated May 10, 2011, 9:58 a.m.) Review request for KDE Base Apps. Changes ------- Now uses KDE --icon option for passivepopup icon, so there are also no string changes (removed --passiveicon explanation from Commandline args) Changed parameter duration (back) to timeout. Summary ------- Since I use kdialog a lot, I wanted it to be able to set an icon for passive Plasma notifications as well. I saw that the icon was hardcoded to dialog-information and tried to enable it to parse the --icon command line argument and pass it to the dbus call that triggers the notification. I could not test the patch however, since I do not (yet) have a full development environment or its dependencies, and I do not even know if this is the right approach, but I hope you can have a look at it. Diffs (updated) ----- kdialog/kdialog.cpp b80ad9a Diff: http://git.reviewboard.kde.org/r/101282/diff Testing ------- Thanks, Kai Uwe
